[U-Boot] [PATCH 2/5] nios2: add Altera EP2C35 board

[Michal Simek]

Thomas Chou wrote:
> This patch supports the Altera CycloneII Nios dev board using
> the example FPGA design at http://nioswiki.com/Linux.
> 
> Signed-off-by: Thomas Chou <thomas at wytron.com.tw>
> ---
>  MAINTAINERS                          |    1 +
>  MAKEALL                              |    1 +
>  Makefile                             |    6 +
>  board/altera/nios2-generic/2c35_cf.h |  757 ++++++++++++++++++++++++++++++++++
>  include/configs/EP2C35.h             |  372 +++++++++++++++++
>  5 files changed, 1137 insertions(+), 0 deletions(-)
>  create mode 100644 board/altera/nios2-generic/2c35_cf.h
>  create mode 100644 include/configs/EP2C35.h

I am strongly against this style of adding any specific nios board to 
U-BOOT.

1. I am not convinced that all information from 2c35_cf.h are important 
for U-BOOT.
What connection has for example "#define KERNEL_REGION_BASE 0xc0000000"?
or others.
+#define PLL_COMPONENT_TYPE altera_avalon_pll
+#define PLL_COMPONENT_NAME pll
+#define PLL_BASE 0x1000020
+#define PLL_SPAN 32

It is the same situation as we solved for Xilinx boards.
Create generic nios board and then generate only parameters which are 
necessary for U-BOOT itself.
For example I am using only one microblaze generic board to cover all 
microblaze boards.
Look at Microblaze or ppc405/440 solution. board/xilinx is good start 
for you.

Wolfgang: Please reject these patches.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian