[U-Boot] [PATCH 1/3] The BUILD_BUG_ON macros moved from ubi_uboot.h to common.h

Michael Zaidman michael.zaidman at gmail.com
Sat Apr 3 10:23:58 CEST 2010


On Fri, Apr 2, 2010 at 9:22 PM, Mike Frysinger <vapier at gentoo.org> wrote:
>>
>> The common.h includes image.h which includes compiler.h, so
>> technically it should works also.
>
> you're looking the wrong direction.  host tools include compiler.h, they dont
> include common.h.

It was clear to me. I meant the u-boot code here.
>
>> I have a doubt however -  what about location of similar staff such as BUG,
>> BUG_ON, debug, error, etc. Should it also be moved into compiler.h file?
>
> many should not.  BUG_ON requires functions that only u-boot implements and
> are not available in host C libraries.

So why do not place all useful staff which pass the compilation into
compiler.h file?

-michael


More information about the U-Boot mailing list