[U-Boot] [PATCH] POST: Added ECC memory test for mpc83xx.

Kim Phillips kim.phillips at freescale.com
Wed Apr 7 02:40:50 CEST 2010


On Tue, 6 Apr 2010 18:29:08 +0300
Michael Zaidman <michael.zaidman at gmail.com> wrote:

> >> Rewriting code to use accessors API added 56 bytes or 14 opcodes. It
> >> doubled the routine's execution time. The routine is called in the
> >> loop per each ecc word, that significantly increased execution time of
> >> the ECC POST test and consequently board startup time.
> >
> > If this is really a problem, you can modify the code to perform the
> > writes without the I/O accessors, and then terminate the block with a
> > sync.
> 
> I thought that is what I actually do in this patch...
> 
> > You should add a comment explaining why you're not using I/O
> > accessors.
> 
> Ok, I will add the explanation.

use raw i/o accessors please.

oh, and don't forget to sign off your work

Thanks,

Kim


More information about the U-Boot mailing list