[U-Boot] [PATCH] [v2] fsl: improve the PIXIS code and fix a few bugs

[Kumar Gala]

On Mar 31, 2010, at 5:44 PM, Timur Tabi wrote:

> Refactor and document the Freescale PIXIS code, used on most 85xx and 86xx
> boards.  This makes the code easier to read and more flexible.
> 
> Delete pixis.h, because none of the exported functions were actually being
> used by any other file.  Make all of the functions in pixis.c 'static'.
> Remove "#include pixis.h" from every file that has it.
> 
> Remove some unnecessary #includes.
> 
> Make 'pixis_base' into a macro, so that we don't need to define it in every
> function.
> 
> Add "while(1);" loops at the end of functions that reset the board, so that
> execution doesn't continue while the reset is in progress.
> 
> Replace in_8/out_8 calls with clrbits_8, setbits_8, or clrsetbits_8, where
> appropriate.
> 
> Replace ulong/uint with their spelled-out equivalents.  Remove unnecessary
> typecasts, changing the types of some variables if necessary.
> 
> Add CONFIG_SYS_PIXIS_VCFGEN0_ENABLE and CONFIG_SYS_PIXIS_VBOOT_ENABLE to make
> it easier for specific boards to support variations in the PIXIS registers
> sets.  No current boards appears to need this feature.
> 
> Fix the definition of CONFIG_SYS_PIXIS_VBOOT_MASK for the MPC8610 HPCD.
> Apparently, "pixis_reset altbank" has never worked on this board.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
> board/freescale/common/pixis.c                |  254 ++++++++++++-------------
> board/freescale/common/pixis.h                |   31 ---
> board/freescale/mpc8536ds/mpc8536ds.c         |    1 -
> board/freescale/mpc8544ds/mpc8544ds.c         |    1 -
> board/freescale/mpc8572ds/mpc8572ds.c         |    1 -
> board/freescale/mpc8610hpcd/mpc8610hpcd.c     |    2 -
> board/freescale/mpc8610hpcd/mpc8610hpcd_diu.c |    1 -
> board/freescale/mpc8641hpcn/mpc8641hpcn.c     |    2 -
> board/freescale/p2020ds/p2020ds.c             |    1 -
> cpu/mpc512x/diu.c                             |    1 -
> include/configs/MPC8610HPCD.h                 |    2 +-
> 11 files changed, 127 insertions(+), 170 deletions(-)
> delete mode 100644 board/freescale/common/pixis.h

applied to 85xx

- k