[U-Boot] [PATCH] fsl-diu: Using I/O accessor to CCSR space

Kumar Gala galak at kernel.crashing.org
Thu Apr 8 17:50:43 CEST 2010


On Apr 8, 2010, at 5:11 AM, Wolfgang Denk wrote:

> Dear "Liu Dave-R63238",
> 
> In message <D7CCA83BB0796C49BC0BB53B6AB12089A9C4E3 at zch01exm21.fsl.freescale.net> you wrote:
>> 
>>> 'ad' should be cast to a u32, not an "unsigned int".  You 
>>> shouldn't compare a sized type with an unsized type.
> ...
> 
>> The u32 is same as "unsigned int".
> 
> Maybe, maybe not. If you want to be safe, then compare u32 with u32
> only.

Good point, I wasn't look at what the src info was.  We should probably fix the struct diu_ad, diu to use 'u32' etc.

- k


More information about the U-Boot mailing list