[U-Boot] [PATCH V5 1/3] Initial support for Marvell Orion5x SoC

[Prafulla Wadaskar]

Dear Albert

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
> Sent: Friday, April 09, 2010 2:41 AM
> To: U-Boot at lists.denx.de
> Subject: [U-Boot] [PATCH V5 1/3] Initial support for Marvell 
> Orion5x SoC
> 
> This patch adds support for the Marvell Orion5x SoC.
> It has no use alone, and must be followed by a patch
> to add Orion5x support for serial, then support for
> the ED Mini V2, an Orion5x-based product from LaCie.
> 
> Signed-off-by: Albert Aribaud <albert.aribaud at free.fr>
> ---
> Patchset history
> 
> V1: Initial monolithic patch.
> V2: split in three patches : orion, serial, edmini;
>     checkpatch'ed, with only 6 errors, in patch 1/3,
>     all 6 errors being false positives.
> V3: useless GPIO and MPP programming support removed;
>     low level init added/CONFIG_SKIP_LOW_LEVEL_INIT removed.
> V4: all files licensed GPLv2-only removed;
>     RAM bank size detection now uses get_ram_size().
> V5: Replaced macros by C structs in dram code.
>     Removed compilation warnings in dram code.
>     Added comments to legacy flash definitions.
>     Split low level init code into SoC- and Chip-specifics.
> 
> Patch 1 of 3 still checkpatches with 6 spurious errors and one
> spurious warning. Patches 2 and 3 have 0 errors and 0 warnings.
> 
>  cpu/arm926ejs/orion5x/Makefile           |   55 ++++++
>  cpu/arm926ejs/orion5x/cpu.c              |  264 
> +++++++++++++++++++++++++++
>  cpu/arm926ejs/orion5x/dram.c             |   63 +++++++
>  cpu/arm926ejs/orion5x/lowlevel_init.S    |  294 
> ++++++++++++++++++++++++++++++
>  cpu/arm926ejs/orion5x/timer.c            |  181 ++++++++++++++++++
>  include/asm-arm/arch-orion5x/cpu.h       |  203 ++++++++++++++++++++
>  include/asm-arm/arch-orion5x/mv88f5182.h |   40 ++++
>  include/asm-arm/arch-orion5x/orion5x.h   |   69 +++++++
>  8 files changed, 1169 insertions(+), 0 deletions(-)
>  create mode 100644 cpu/arm926ejs/orion5x/Makefile
>  create mode 100644 cpu/arm926ejs/orion5x/cpu.c
>  create mode 100644 cpu/arm926ejs/orion5x/dram.c
>  create mode 100644 cpu/arm926ejs/orion5x/lowlevel_init.S
>  create mode 100644 cpu/arm926ejs/orion5x/timer.c
>  create mode 100644 include/asm-arm/arch-orion5x/cpu.h
>  create mode 100644 include/asm-arm/arch-orion5x/mv88f5182.h
>  create mode 100644 include/asm-arm/arch-orion5x/orion5x.h
> 
> diff --git a/cpu/arm926ejs/orion5x/Makefile 
> b/cpu/arm926ejs/orion5x/Makefile
> new file mode 100644
> index 0000000..86932ca
> --- /dev/null
> +++ b/cpu/arm926ejs/orion5x/Makefile
> @@ -0,0 +1,55 @@
> +#
> +# Copyright (C) 2009 Albert ARIBAUD <albert.aribaud at free.fr>

General comment for all files,
You should change copyright statement for year 2010 instead of 2009 

...snip...
+/*
+ * Orion5x identification is done through PCIE space.
+ */
+#define PCIE_DEV_ID_OFF         (ORION5X_REG_PCIE_BASE + 0x0000)
+#define PCIE_DEV_REV_OFF        (ORION5X_REG_PCIE_BASE + 0x0008)

These are already defined cpu.h, pls remove it
 
+u32 orion5x_device_id(void)
+{
+	return readl(PCIE_DEV_ID_OFF) >> 16;
+}
+

...snip...
> diff --git a/cpu/arm926ejs/orion5x/lowlevel_init.S 
> b/cpu/arm926ejs/orion5x/lowlevel_init.S
> new file mode 100644
> index 0000000..7e5a032
> --- /dev/null
> +++ b/cpu/arm926ejs/orion5x/lowlevel_init.S
> @@ -0,0 +1,294 @@
> +/************************************************************
> *******************
> +Copyright (c) Albert ARIBAUD <albert.aribaud at free.fr>
> +Redistributed under GPLv2, pursuant to the licensing terms
> +of the original Marvell U-boot code which is:
> +Copyright (C) Marvell International Ltd. and its affiliates
> +*************************************************************
> *******************
> +Marvell GPL License Option

You should put standard GPL statement here as you put for other files,
Also pls remove Marvell GPL statement

> +
> +If you received this File from Marvell, you may opt to use, 
> redistribute and/or
> +modify this File in accordance with the terms and conditions 
> of the General
> +Public License Version 2, June 1991 (the "GPL License"), a 
> copy of which is
> +available along with the File in the license.txt file or by 
> writing to the Free
> +Software Foundation, Inc., 59 Temple Place, Suite 330, 
> Boston, MA 02111-1307 or
> +on the worldwide web at http://www.gnu.org/licenses/gpl.txt.
> +
> +THE FILE IS DISTRIBUTED AS-IS, WITHOUT WARRANTY OF ANY KIND, 
> AND THE IMPLIED
> +WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR 
> PURPOSE ARE EXPRESSLY
> +DISCLAIMED.  The GPL License provides additional details 
> about this warranty
> +disclaimer.
> +
> +*************************************************************
> ******************/

Apart from above, the code looks okay to me.

Regards..
Prafulla . .