[U-Boot] [PATCH 1/4] s5p6442: Support Samsung s5p6442 SoC

[Wolfgang Denk]

Dear Minkyu Kang,

In message <1f3430fb1003301842kbff3d1fie305bb7c6bd21261 at mail.gmail.com> you wrote:
> 
> These registers are used at asm code.

Are they only used in assembler code? If so, these defines should be
moved to a separate asm-offsets.h file. Keep in mind that this is
considered to be a temporary workaround only. Later this file will be
removed, and then auto-generated from the respective C structs. As
soon as somebody finds time to adapt the respective code from Linux,
that is.

> So, can't make C struct.
> But, It seemed to there are defined unused registers also.
> 
> Joonyoung,
> Please remove unused defines.

And move this definition to asm-offsets.h (which must not be included
in any C code).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A wise person makes his  own  decisions,  a  weak  one  obeys  public
opinion.                                           -- Chinese proverb