[U-Boot] [PATCH 2/2] add support of arm/pxa270 board made by voipac

Wolfgang Denk wd at denx.de
Sat Apr 10 00:41:26 CEST 2010


Dear Mikhail Kshevetskiy,

In message <20100407154622.316be1f2 at laska.campus-ws.pu.ru> you wrote:
> 
> Here is my comments to your notices,
> the updated patch is in the following letter.

Thanks.

> I try to keep lowlevel_init.S as much close to the same file from board/trizeptiv
> as it was possible, so initially i keep formatting and comments style from the
> upstream version of board/trizeptiv/lowlevel_init.S.

I see. But a bad example is no reason to keep this style. Please fix.

> the similar or exactly the same peace of code can be found in lowlevel
> initialization of almost all arm/pxa boards, so i think it is reasonable to keep
> this code in place.

The fact that we accepted poor code in the past ist no reason not to
try to improve over time.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Intelligence without character is a dangerous thing."   - G. Steinem


More information about the U-Boot mailing list