[U-Boot] [PATCH] PXA: Align stack to 8 bytes
Marek Vasut
marek.vasut at gmail.com
Sun Apr 11 09:21:56 CEST 2010
Stack must be aligned to 8 bytes on PXA (possibly all armv5te) for LDRD/STRD
instructions. In case LDRD/STRD is issued on an unaligned address, the behaviour
is undefined.
The issue was observed when working with the NAND code, which was rendered
disfunctional. Also, the vsprintf() function had serious problems with printing
64bit wide long longs. After aligning the stack, this wrong behaviour is no
longer present.
Tested on:
Marvell Littleton PXA310 board
Toradex Colibri PXA320 board
Aeronix Zipit Z2 PXA270 handheld
Voipac PXA270 board
Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
---
cpu/pxa/start.S | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/cpu/pxa/start.S b/cpu/pxa/start.S
index 13e2edb..bbfcfd1 100644
--- a/cpu/pxa/start.S
+++ b/cpu/pxa/start.S
@@ -140,7 +140,10 @@ stack_setup:
#ifdef CONFIG_USE_IRQ
sub r0, r0, #(CONFIG_STACKSIZE_IRQ+CONFIG_STACKSIZE_FIQ)
#endif /* CONFIG_USE_IRQ */
- sub sp, r0, #12 /* leave 3 words for abort-stack */
+ bic sp, r0, #7 /* leave 4 words for abort-stack */
+ /* NOTE: stack MUST be aligned to */
+ /* 8 bytes in case we want to use */
+ /* 64bit datatypes (eg. VSPRINTF64) */
clear_bss:
ldr r0, _bss_start /* find start of bss segment */
--
1.7.0
More information about the U-Boot
mailing list