[U-Boot] [PATCH 1/2] mpc83xx: Fix comments on map_flash_by_law1

Gao Ya'nan abutter.gao at gmail.com
Sun Apr 11 14:30:09 CEST 2010


2010/4/11 Wolfgang Denk <wd at denx.de>:
> Dear Gao Ya'nan,
>
> In message <1270944532-2050-1-git-send-email-abutter.gao at gmail.com> you wrote:
>> ---
>>  cpu/mpc83xx/start.S |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>
>
> When reposting patches, please ALWAYS mark these as a new version in
> the Subject line, like this: "[PATCH 1/2 v2]".
>
> Also, please make sure that your mailer adds or keeps correct
> In-reply-to: and References:  headers, so threading of messages is
> working and everybody can see that this reefers to some older posting
> of the same topic.
>
> Finally, add a changelog below the "---" line, where you explain what
> exactly has been changed compare to the previous version.
>

Sorry, I'm a git newbie and post patch for u-boot first time.

> Here, I see zero difference between your first patch and this one,
> except for the slight change of the subject line.
>

And I thought I should highlight "mpc83xx".

>
> Such uncommented and un-threaded repostings are extremely annoying
> and time-consuming, as we have to try to remember if anything similkar
> has been posted before, look up th eold threads, and then manually
> compare if anything has been changesd, or what.
>
>
> Thanks.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> The explanation requiring the fewest assumptions is the  most  likely
> to be correct.                                    -- William of Occam
>


More information about the U-Boot mailing list