On 04/17/2010 10:18 PM, Sergei Shtylyov wrote: >> +static inline void gpio_set_value(unsigned gpio, int value) >> +{ >> + writel(value ? 3 : 2, CONFIG_SYS_GPIO_BASE + ((gpio) << 2)); >> +} > > > Why enclose 'gpio' into () when it's not within a macro? > Hi Sergei, Right. It is not not needed. Thanks. Best regards, Thomas