[U-Boot] [PATCH] KGDB set / remove breakpoints

[Tonny Tzeng]

Thanks for the review, Mike.

>> Please note, after applying this patch, those architectures, which
>> already enabled KGDB support, have to create a new asm/kgdb.h and
>> define the length of the break instruction (BREAK_INSTR_SIZE) in that
>> file.
>
> i dont think breaking build is a good idea.  i would have the code simply
> disable itself if BREAK_INSTR_SIZE isnt set.

That's why I used ifndef in the previous patch, and set
BREAK_INSTR_SIZE to 4 if it isn't set, but I thought you prefer "an
undefined size should be used as a tip that the arch doesnt yet
support break points"?

In Linux kgdb code, there is an arch independent header file
include/linux/kgdb.h, which includes arch dependent header asm/kgdb.h.
 I am trying to include this concept here, unfortunately current
u-boot code only has linux/kgdb.h, if we want to define arch specific
code in asm/kgdb.h, we may need to include asm/kgdb.h from
linux/kgdb.h, so it looks to me it will definitely break other arch,
do you have any suggestion for that?

Best Regards,
Tonny