[U-Boot] [PATCH 10/17] SPEAr : FSMC driver support added

[Scott Wood]

Vipin KUMAR wrote:
> On 4/21/2010 10:32 PM, Scott Wood wrote:
>> On Wed, Apr 21, 2010 at 01:24:36PM +0530, Vipin KUMAR wrote:
>>> +#if defined(CONFIG_BOARD_NAND_LP)
>> CONFIG_SYS_FSMC_NAND_LP, CONFIG_SYS_FSMC_NAND_16BIT, etc.
> 
> Incomplete comment :)
> Are these deprecated

CONFIG symbols that are hardware parameters rather than user-tweakable 
config go in the CONFIG_SYS namespace (see "Software Configuration" in 
README).

I think it should also be an FSMC-specific parameter, not something that 
looks universal.

>>> +#ifndef __FSMC_NAND_H__
>>> +#define __FSMC_NAND_H__
>>> +
>>> +struct fsmc_regs {
>>> +	u8 reserved_1[0x40];
>>> +	u32 genmemctrl_pc;		/* 0x40 */
>>> +	u32 genmemctrl_sts;		/* 0x44 */
>>> +	u32 genmemctrl_comm;		/* 0x48 */
>>> +	u32 genmemctrl_attrib;		/* 0x4c */
>>> +	u32 genmemctrl_ioata;		/* 0x50 */
>>> +	u32 genmemctrl_ecc1;		/* 0x54 */
>>> +	u32 genmemctrl_ecc2;		/* 0x58 */
>>> +	u32 genmemctrl_ecc3;		/* 0x5c */
>>> +	u8 reserved_2[0xfe0 - 0x60];
>>> +	u32 genmemctrl_peripid0;	/* 0xfe0 */
>>> +	u32 genmemctrl_peripid1;	/* 0xfe4 */
>>> +	u32 genmemctrl_peripid2;	/* 0xfe8 */
>>> +	u32 genmemctrl_peripid3;	/* 0xfec */
>>> +	u32 genmemctrl_pcellid0;	/* 0xff0 */
>>> +	u32 genmemctrl_pcellid1;	/* 0xff4 */
>>> +	u32 genmemctrl_pcellid2;	/* 0xff8 */
>>> +	u32 genmemctrl_pcellid3;	/* 0xffc */
>>> +};
>> Is the genmemctrl_ prefix really needed?
>>
> 
> The peripheral's registers are named like these so I kept it.

The struct name takes that role here; hardware documentation doesn't 
have the benefit of that.

-Scott