[U-Boot] [PATCH RFC v3] add CONFIG_BOOTCOUNT_LIMIT for MCF5445x

Wolfgang Wegner wolfgang at leila.ping.de
Sat Apr 24 11:45:49 CEST 2010


Dear Wolfgang Denk,

On Sat, Apr 24, 2010 at 12:27:42AM +0200, Wolfgang Denk wrote:
> Dear Wolfgang Wegner,
> 
> In message <20100423205938.GU20047 at leila.ping.de> you wrote:
> > This patch adds bootcount for Freescale MCF5445x. Two registers of
> > eDMA transfer control descriptors (TCD[1]) are used because these
> > are unused by linux kernel (freescale LTIB linux-2.6.25) and were
> > tested to keep their contents across resets.
> > TCD[1] is currently unused by the linux drivers, so using its registers
> > should be safe as long as no non-standard driver is loaded.
> > 
> > Signed-off-by: Wolfgang Wegner <w.wegner at astro-kom.de>
> > ---
> > I implemented and tested this bootcount on a custom MCF54455 board.
> > According to the data sheet, the internal SRAM is not supposed to be
> > useful for data storage across resets. There is no explicit statement
> > concerning the TCD registers, but in tests on our board the values
> > did always survive reset.
> > v2: updated comment
> > v3: moved updated comment to the right place :-)
> 
> Did you???

The part about how long the registers are untouched by other drivers -
yes. The other part not.
Originally the other part of the comment was more or less meant to be a
hint for others (probably having more experience with coldfire than me)
reviewing the patch, so that I could afterwards provide a completely
revised version.
Looking at it today, I should simply have moved everything up to the
commit message, but as it is now, I should probably simply wait to let
others comment before sending another patch?

Best regards,
Wolfgang



More information about the U-Boot mailing list