[U-Boot] [PATCH] PXAMMC: Drop different delays for PXA27X

[Marek Vasut]

Dne So 24. dubna 2010 03:39:24 Andy Fleming napsal(a):
> On Fri, Apr 23, 2010 at 8:29 PM, Marek Vasut <marek.vasut at gmail.com> wrote:
> > Dne So 24. dubna 2010 03:13:07 Andy Fleming napsal(a):
> >> On Sun, Apr 4, 2010 at 7:32 PM, Marek Vasut <marek.vasut at gmail.com> wrote:
> >> > In case the delays were set to 10000, the MMC card on PXA27X boards
> >> > (and PXA3xx boards) didn't initialize on first try. Increasing the
> >> > delays and leaving just those for PXA25x and 26x (that is 200000)
> >> > fixes this problem.
> >> 
> >> In general, I object to board-specific #ifdefs in drivers.
> > 
> > This is not a board specific ifdef.
> 
> I'm sorry, I misread the patch completely.  I assumed you were adding
> the #ifdefs, instead of removing them, as that is the usual pattern,
> and I had misunderstood your patch description.  200000us is a long
> time.  Are you sure it's necessary (would 100000 work)?  Let me know,
> and I'll apply this patch.

Good. I haven't tested with shorter delays, but how would that matter? If the 
card times out, it's bad none the less. If it doesn't, the whole delay isn't 
used anyway.

We can adjust this timing in another patch though. As it is now, it works fine 
for both PXA27x and PXA3xx and also doesn't break PXA25x -- that's why I'd 
better avoid mixing it into one patch.
> 
> Andy