[U-Boot] [PATCH] bootdelay can be an environemt variable

Matthias Weißer weisserm at arcor.de
Tue Apr 27 11:31:32 CEST 2010


Am 27.04.2010 10:19, schrieb Wolfgang Denk:
> Dear Matthias Weisser,
>
> In message<1272348834-30161-1-git-send-email-weisserm at arcor.de>  you wrote:
>> This patch allows the bootdelay variable contain the name of
>> another variable holding the actual bootdelay value.
>
> Why make the "bootdelay" variable in any way special, compared to all
> other variables? Such inconsistent handling makes no sense to me and
> will only confuse users (not to mentiuon that you don't even attempt
> to document the change).
>
> NAK.
>
> If you need any such evaluation, then perform it for example as part
> of a PREBOOT command. This allows you to do the same thing, in a clean
> way.

It was an attempt to get the bootdelay in an environment variable which 
can be overridden by board specific code.

With this I tried to follow your suggestion in 
http://lists.denx.de/pipermail/u-boot/2010-April/070431.html where you 
NAKed the direct override of bootdelay in board_late_init. So, currently 
my setup is:

bootdelay=gs_bootdelay

and in board.c I set gs_bootdelay according to some GPIO states. Another 
user of the board could simply change bootdelay to an integer and get 
rid of the boards behavior.

I don't see a way to achieve this with a PREBOOT command.

Is there a way that you accept the patch if I add a sentence or two to 
the README?

Regards,
Matthias


More information about the U-Boot mailing list