[U-Boot] [PATCH] powerpc: Consolidate bootcount_{store|load} for PowerPC

[Detlev Zundel]

Hi Stefan,

> This patch consolidates bootcount_{store|load} for PowerPC by
> implementing a common version in arch/powerpc/lib/bootcount.c. This
> code is now used by all PowerPC variants that currently have these
> functions implemented.
>
> The functions now use the proper IO-accessor functions to read/write the
> values.
>
> This code also supports two different bootcount versions:
>
> a) Use 2 seperate words (2 * 32bit) to store the bootcounter
> b) Use only 1 word (2* 16bit) to store the bootcounter
>
> Version b) was already used by MPC5xxx.
>
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Michael Zaidman <michael.zaidman at gmail.com>
> Cc: Wolfgang Denk <wd at denx.de>
> Cc: Kim Phillips <kim.phillips at freescale.com>
> Cc: Anatolij Gustschin <agust at denx.de>

Cool, thanks!

I have only a cosmetic suggestion - can we rename the option
CONFIG_SYS_BOOTCOUNT_USE_32BIT to CONFIG_SYS_BOOTCOUNT_SINGLEWORD?
According to your documentation this would describe the situation
somewhat closer.

Apart from that:

Acked-by: Detlev Zundel <dzu at denx.de>

Cheers
  Detlev

-- 
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de