[U-Boot] [PATCH] MX31: Adjust default environment for QONG module

[Stefano Babic]

Wolfgang Denk wrote:
>>  	"ramdisk_addr=a0300000\0"					\
> =========^^^^^^^^^^^^^^^^^^^^^
> 
>>  	"u-boot=qong/u-boot.bin\0"					\
>>  	"kernel_addr_r=80800000\0"					\
>> @@ -274,7 +274,7 @@ extern int qong_nand_rdy(void *chip);
>>  #define CONFIG_FLASH_CFI_MTD
>>  #define MTDIDS_DEFAULT		"nor0=physmap-flash.0"
>>  #define MTDPARTS_DEFAULT	\
>> -	"mtdparts=physmap-flash.0:256k(U-Boot),128k(env1),"	\
>> +	"mtdparts=physmap-flash.0:384k(U-Boot),128k(env1),"	\
>>  	"128k(env2),2560k(kernel),13m(ramdisk),-(user)"
> 
> This shifts the start address of the "ramdisk' and "user" partitions
> to some odd addresses; also, this makes the definition of
> "ramdisk_addr" (see above) incorrct.

You are right. The ramdisk_addr must be shifted, or the kernel size must
be adjusted.

> I recommend to do this instead:
> 
> -	"mtdparts=physmap-flash.0:256k(U-Boot),128k(env1),"	\
> -	"128k(env2),2560k(kernel),13m(ramdisk),-(user)"
> +	"mtdparts=physmap-flash.0:384k(U-Boot),128k(env1),"	\
> +	"128k(env2),2432k(kernel),13m(ramdisk),-(user)"
>  
> 
> What do you think?

Agree. I will send a new version of the patch with your proposed values.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================