[U-Boot] [PATCH] mpc83xx: Add UPMA configuration to SIMPC8313

Kim Phillips kim.phillips at freescale.com
Thu Apr 29 01:05:48 CEST 2010


On Wed, 28 Apr 2010 15:18:36 -0700
Ron Madrid <ron_madrid at sbcglobal.net> wrote:

> > > +    /* Set LUPWAIT to be active low
> > and enabled */
> > > +    *mxmr = 0x08000000 |
> > MxMR_GPL_x4DIS;
> > 
> > ...because we should now be using i/o accessors. 
> 
> Not entirely sure what you mean here.  Should I be
> using __raw_writel, or writel, or ...?

out_be32 (or even setbits_be32) looks appropriate here.  The raw
accessors can be used as an alternative when performance and/or code
density issues arise.

Kim


More information about the U-Boot mailing list