[U-Boot] [PATCH] tsec: Revert to setting TBICR_ANEG_ENABLE by default for SGMII

Peter Tyser ptyser at xes-inc.com
Thu Dec 2 17:50:12 CET 2010


Hi Kumar,

> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>

Acked-by: Peter Tyser <ptyser at xes-inc.com>
Tested-by: Peter Tyser <ptyser at xes-inc.com>

<snip>

> index e0a1fa4..9d87eaf 100644
> --- a/include/configs/xpedite537x.h
> +++ b/include/configs/xpedite537x.h
> @@ -375,6 +375,12 @@ extern unsigned long get_board_ddr_clk(unsigned long dummy);
>  #define CONFIG_MII_DEFAULT_TSEC	1	/* Allow unregistered phys */
>  #define CONFIG_ETHPRIME		"eTSEC2"

Would you mind adding a comment along the lines of the following to
xpedite537x.h and xpedite550x.h above the CONFIG_TSEC_TBICR_SETTINGS
define?:
/*
 * In-band SGMII auto-negotiation between TBI and BCM5482S PHY fails, force
 * 1000mbps SGMII link
 */

> +#define CONFIG_TSEC_TBICR_SETTINGS ( \
> +		TBICR_PHY_RESET \
> +		| TBICR_FULL_DUPLEX \
> +		| TBICR_SPEED1_SET \
> +		)
> +

Thanks,
Peter




More information about the U-Boot mailing list