[U-Boot] [PATCH 08/13] SBC8560: #define CONFIG_SYS_LBC_NO_SDRAM_INIT

Peter Tyser ptyser at xes-inc.com
Fri Dec 3 22:22:31 CET 2010


On Fri, 2010-12-03 at 14:54 -0600, Becky Bruce wrote:
> On Dec 2, 2010, at 8:26 PM, Peter Tyser wrote:
> 
> > Hi Becky,
> > 
> >> +/* Common ddr init for non-corenet fsl 85xx platforms */
> >> +#ifndef CONFIG_FSL_CORENET
> >> +phys_size_t initdram(int board_type)
> >> +{
> >> +	phys_size_t dram_size = 0;
> >> +
> >> +	puts("Initializing\n");
> > 
> > Any chance we can remove the puts() above?  "DRAM:" is always printed
> > out directly before initdram is called, so I don't think the
> > "Initializing" message adds much benefit and slightly dirties the
> > output.  For reference:
> 
> That's fine with me.... does anybody object to this?  It's certainly easy to change this now.

I just noticed it now, but I'd also be in favor of getting rid of the
"DDR:" puts() at the end of initdram().  It doesn't add much value since
the specific DDR type is already printed out in board_add_ram_info().

Best,
Peter



More information about the U-Boot mailing list