[U-Boot] [RFC 1/3] tools/env: Default to the config specified in FW_CONFIG_FILE

Steve Sakoman steve at sakoman.com
Sat Dec 4 15:44:24 CET 2010


On Sat, 2010-12-04 at 05:34 -0500, Mike Frysinger wrote:
> On Friday, December 03, 2010 23:28:51 Steve Sakoman wrote:
> > +	if (!config_file || !strlen(config_file)) {
> 
> strlen is a bad bad idea.  if you only want to see if it's non-empty, check 
> the first byte.

I'll correct this in the next revision.

Thanks for reviewing the code!

Steve



More information about the U-Boot mailing list