[U-Boot] [PATCH 2/6 v2] LZMA: Avoid free on null pointer

Wolfgang Denk wd at denx.de
Sat Dec 4 23:24:54 CET 2010


Dear Luigi 'Comio' Mantellini,

In message <1291469358-25023-3-git-send-email-luigi.mantellini at idf-hit.com> you wrote:
> 
> Signed-off-by: Luigi 'Comio' Mantellini <luigi.mantellini at idf-hit.com>
> ---
>  lib/lzma/LzmaDec.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/lzma/LzmaDec.c b/lib/lzma/LzmaDec.c
> index f941da2..b2a3aec 100644
> --- a/lib/lzma/LzmaDec.c
> +++ b/lib/lzma/LzmaDec.c
> @@ -913,7 +913,9 @@ SRes LzmaDec_DecodeToBuf(CLzmaDec *p, Byte *dest, SizeT *destLen, const Byte *sr
>  
>  void LzmaDec_FreeProbs(CLzmaDec *p, ISzAlloc *alloc)
>  {
> -  alloc->Free(alloc, p->probs);
> +  if (p->probs) {
> +    alloc->Free(alloc, p->probs);
> +  }
>    p->probs = 0;
>  }

Incorrect indentation, and no braces needed for single line
statements.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A mouse is an elephant built by the Japanese.


More information about the U-Boot mailing list