[U-Boot] [PATCH 6/6 v2] Enable bootstrap code for QEMU-MIPS board.

[Wolfgang Denk]

Dear Luigi 'Comio' Mantellini,

In message <1291469358-25023-7-git-send-email-luigi.mantellini at idf-hit.com> you wrote:
> 
> Signed-off-by: Luigi 'Comio' Mantellini <luigi.mantellini at idf-hit.com>
> ---
>  board/qemu-mips/Makefile              |   15 ++++++-
>  board/qemu-mips/config.mk             |    7 ++-
>  board/qemu-mips/qemu-mips_bootstrap.c |   48 +++++++++++++++++++++
>  board/qemu-mips/u-boot-bootstrap.lds  |   73 +++++++++++++++++++++++++++++++++
>  include/configs/qemu-mips.h           |   15 ++++++-
>  5 files changed, 154 insertions(+), 4 deletions(-)
>  create mode 100644 board/qemu-mips/qemu-mips_bootstrap.c
>  create mode 100644 board/qemu-mips/u-boot-bootstrap.lds
...
> --- a/board/qemu-mips/config.mk
> +++ b/board/qemu-mips/config.mk
> @@ -3,8 +3,11 @@
>  # See http://fabrice.bellard.free.fr/qemu
>  #
>  
> +ifeq ($(CONFIG_BOOTSTRAP),)
>  # ROM version
>  CONFIG_SYS_TEXT_BASE = 0xbfc00000
> -
> +else
>  # RAM version
> -#CONFIG_SYS_TEXT_BASE = 0x80001000
> +CONFIG_SYS_TEXT_BASE = 0x80001000
> +CONFIG_BOOTSTRAP_TEXT_BASE = 0xbfc00000

Please move all thse settings out of the config.mk into the board
config file.

> +endif
> \ No newline at end of file

Fix this too, please.


> diff --git a/include/configs/qemu-mips.h b/include/configs/qemu-mips.h
> index fb697d5..2337a32 100644
> --- a/include/configs/qemu-mips.h
> +++ b/include/configs/qemu-mips.h
> @@ -114,7 +114,7 @@
>  #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)  /* Print Buffer Size */
>  #define CONFIG_SYS_MAXARGS		16		/* max number of command args */
>  
> -#define CONFIG_SYS_MALLOC_LEN		128*1024
> +#define CONFIG_SYS_MALLOC_LEN		4*1024*1024

Is this unconditionally needed?

> +/* Support for compressed u-boot image */
> +#define CONFIG_BOOTSTRAP
> +#ifdef CONFIG_BOOTSTRAP
> +#define CONFIG_BOOTSTRAP_BASE			CONFIG_BOOTSTRAP_TEXT_BASE
> +#define CONFIG_BOOTSTRAP_BAUDRATE		CONFIG_BAUDRATE
> +#define CONFIG_SKIP_LOWLEVEL_INIT
> +// #define CONFIG_BOOTSTRAP_BZIP2			/* Use BZIP2 payload */
> +// #define CONFIG_BOOTSTRAP_GZIP			/* Use GZIP payload */
> +// #define CONFIG_BOOTSTRAP_LZMA			/* Use LZMA payload */
> +// #define CONFIG_BOOTSTRAP_LZO			/* Use LZO payload */
> +#define CONFIG_BOOTSTRAP_XZ					/* Use XZ payload */
> +#endif

C++ comments not allowed.  And please do not add dead code.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Why should we subsidize intellectual curiosity?" - Ronald Reagan