[U-Boot] [PATCH] LZMA: Avoid free on null pointer.

Luigi Mantellini luigi.mantellini.ml at gmail.com
Mon Dec 6 10:13:11 CET 2010


On Mon, Dec 6, 2010 at 9:57 AM, Mike Frysinger <vapier at gentoo.org> wrote:
>
> sorry, but this is not an acceptable reason.  so unless you have an actual
> error report here, your patch gets NAK-ed.
> -mike
>

Hi mike,

my pov is different: free should (must) be called only on already
allocated pointers. I know that free code checks at begin if ptr is
null or not. Anyway I don't understand why a null pointer check before
to call free cannot be added to the code... it's safe and follows the
logical flow of the code.

I received warning from my debugger during activities on other things,
and I added this fix to my code to turn-off "possible free on null
pointer" warning from my debugger.

my 2Cents,

ciao ciao

luigi
-- 
Luigi 'Comio' Mantellini
R&D - Software
Industrie Dial Face S.p.A.
Via Canzo, 4
20068 Peschiera Borromeo (MI), Italy

Tel.: +39 02 5167 2813
Fax: +39 02 5167 2459
web: www.idf-hit.com
mail: luigi.mantellini at idf-hit.com


More information about the U-Boot mailing list