[U-Boot] [PATCH] ppc: transform init_sequence into a function.

Graeme Russ graeme.russ at gmail.com
Tue Dec 7 00:06:56 CET 2010


On Tue, Dec 7, 2010 at 9:36 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Joakim Tjernlund,
>
> In message <OFEE7ADEEA.47556DD1-ONC12577F1.006FAF8D-C12577F1.0071C097 at transmode.se> you wrote:
>>

[snip]

>> The other way is to look up one those funs and set a BP there and hope
>> for the best. Then repeat with the next function and so on.
>> Compare that with just setting a BP in the new init_sequence(), it is
>> fast and easy to move around.
>
> ...but ugly to read.  And if you really want to introduce this style,
> it has to be done for all architectures, as I want to see this code to
> become common across architectures.
>

Moving away from the array based init sequence also promotes the posibility
to break away from the very strict function prototype (void parameter
returning int) which will lead to even more ugliness in the future

Regards,

Graeme


More information about the U-Boot mailing list