[U-Boot] [PATCH v4 2/7] gpio: Add Multi-Function-Pin configuration driver for Marvell SoCs

[Albert ARIBAUD]

Le 07/12/2010 18:10, Prafulla Wadaskar a écrit :

>>> +                       val&= ~MFP_AF_MASK;
>> Do we need to do this&  here? For val is only 0 here...
>
> This can be removed.

OTOH, with the &, this line makes no assumption about val, and thus will 
work regardless of it. If the & is removed, and if later val is set to 
non-zero before reaching this instruction, it will cause a bug.

IOW, the & makes the statement more resilient.

Amicalement,
-- 
Albert.