[U-Boot] [PATCH 3/4] arm920t: fix linker skript for -pie linking
Albert ARIBAUD
albert at aribaud.net
Thu Dec 9 08:33:12 CET 2010
Le 09/12/2010 08:24, Andreas Bießmann a écrit :
> Dear Wolfgang Denk,
>
> Am 08.12.2010 um 23:52 schrieb Wolfgang Denk:
>
>> Dear =?UTF-8?q?Andreas=20Bie=C3=9Fmann?=,
>>
>> In message<1291099039-49672-4-git-send-email-andreas.devel at googlemail.com> you wrote:
>>> Without this patch the linker will SEGFAULT on some undefined weak
>>> symbols.
>>>
>>> Suggested-by: Sebastien Carlier<sebastien.carlier at gmail.com>
>>> Signed-off-by: Andreas Bießmann<andreas.devel at googlemail.com>
>>> ---
>>> arch/arm/cpu/arm920t/u-boot.lds | 3 +++
>>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> Applied, thanks.
>
> Please do not apply that patch! I'm sorry I have split up the thread cause it lead to a generic timer discussion. Therefore I posted v2 of this patch series here:
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/89974
>
> This patch is not needed, if no undefined weak symbol is available.
> This patch adds .plt/.rel.plt section which has R_ARM_JUMP_SLOT which is not handled in code. Therefore we do not really know what this patch does to the code, it was mostly a patch to handle the linker segfault described several times.
Thanks for pointing this out. My bad: I did not relate the two series
when going through patchwork.
Wolfgang, I was about to send out a revert but after pulling u-boot.git
and u-boot-arm.git I don't see Andreas' patch in there. If you haven't
committed it yet, maybe you can fix this yourself?
> regards
>
> Andreas Bießmann
Amicalement,
--
Albert.
More information about the U-Boot
mailing list