[U-Boot] [PATCH] ppc4xx: 460SX Eegier board support

[Wolfgang Denk]

Dear tmarri at apm.com,

In message <1291857127-3265-1-git-send-email-tmarri at apm.com> you wrote:
> 
> Adding Eiger board support for 460SX SoC.

I understand the "Eegier" in the Subject: is a typo?  That shouldbe
"Eiger" as well?

> +########################################################################
> diff --git a/board/amcc/eiger/config.mk b/board/amcc/eiger/config.mk
> new file mode 100644
> index 0000000..aa6cbda
> --- /dev/null
> +++ b/board/amcc/eiger/config.mk
...
> +PLATFORM_CPPFLAGS += -DCONFIG_440=1
> +
> +ifeq ($(debug),1)
> +PLATFORM_CPPFLAGS += -DDEBUG
> +endif
> +
> +ifeq ($(dbcr),1)
> +PLATFORM_CPPFLAGS += -DCONFIG_SYS_INIT_DBCR=0x8cff0000
> +endif

I don't think any of this is needed.  Please get rid of the consif.mk
file.

> --- /dev/null
> +++ b/board/amcc/eiger/init.S
> @@ -0,0 +1,67 @@
...
> +	/*
> +	 * BOOT_CS (FLASH) must be first. Before relocation SA_I can be off to use the
> +	 * speed up boot process. It is patched after relocation to enable SA_I
> +	 */

Lines too long. Please fix globally.

> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -641,6 +641,7 @@ bubinga                      powerpc     ppc4xx      -                   amcc
>  canyonlands                  powerpc     ppc4xx      canyonlands         amcc           -           canyonlands:CANYONLANDS
>  canyonlands_nand             powerpc     ppc4xx      canyonlands         amcc           -           canyonlands:CANYONLANDS,NAND_U_BOOT,SYS_TEXT_BASE=0x01000000
>  ebony                        powerpc     ppc4xx      -                   amcc
> +eiger                        powerpc ppc4xx          -                   amcc

Could you please use the same vertical alignment as the ebony board
above?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are things that are so serious that you can  only  joke  about
them"                                                    - Heisenberg