[U-Boot] [PATCH 02/10] make the hwconfig buffer deeper

[Wolfgang Denk]

Dear York Sun,

In message <1291863340-4354-2-git-send-email-yorksun at freescale.com> you wrote:
> To temporarily fix buffer issue when running at flash, use bigger buffer
> to push down the stack deeper.

What does this mean? "temporarily fix" ? Do you have another,
permanent fix in the works

> Signed-off-by: York Sun <yorksun at freescale.com>
> ---
>  common/hwconfig.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/hwconfig.c b/common/hwconfig.c
> index 3c9759f..1b33d95 100644
> --- a/common/hwconfig.c
> +++ b/common/hwconfig.c
> @@ -71,7 +71,7 @@ next:
>  const char *cpu_hwconfig __attribute__((weak));
>  const char *board_hwconfig __attribute__((weak));
>  
> -#define HWCONFIG_PRE_RELOC_BUF_SIZE	128
> +#define HWCONFIG_PRE_RELOC_BUF_SIZE	256

Is this really, really necessary?  Memory is a scarce resource
pre relocation.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If it happens once, it's a bug.
If it happens twice, it's a feature.
If it happens more than twice, it's a design philosophy.