[U-Boot] [PATCH] ftgmac100: support of gigabit eth ftgmac100

Wolfgang Denk wd at denx.de
Mon Dec 13 06:38:30 CET 2010


Dear Macpaul Lin,

In message <AANLkTikJM4hAw8yAWeUPiumiiN3vr9qgY-TT8KyYuSVZ at mail.gmail.com> you wrote:
> 
> Please take a look at the similar driver "ftmac100.c",
> Some coding patterns in "ftgmac100.c" are followed as "ftmac100.c".

Oh. Thanks for pointing out.  So this other driver needs to be fixed,
too.

> So I think you've permit that kind of coding style and related issues,
> this code of ftgmac100 shouldn't be a problem. ;p

The fact that some bad code slips through a review does not mean that
it's blessed.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The number  of  Unix  installations  has  grown  to  10,  with  more
expected."    - The Unix Programmer's Manual, 2nd Edition, June, 1972


More information about the U-Boot mailing list