[U-Boot] [PATCH 05/10] Adding more registers and options

[York Sun]

On Tue, 2010-12-14 at 00:37 -0600, Kumar Gala wrote:
> On Dec 14, 2010, at 12:30 AM, York Sun wrote:
> 
> > On Mon, 2010-12-13 at 23:10 -0600, Kumar Gala wrote:
> >> On Dec 8, 2010, at 8:55 PM, York Sun wrote:
> >> 
> >>> Add writing to cdr1, cdr2, err_disable, err_int_en and debug registers
> >>> Add options to override rcw, address parity to RDIMMs.
> >>> Use array for debug registeres.
> >>> 
> >>> Signed-off-by: York Sun <yorksun at freescale.com>
> >>> ---
> >>> arch/powerpc/cpu/mpc85xx/ddr-gen3.c      |   10 ++++++++--
> >>> arch/powerpc/include/asm/fsl_ddr_sdram.h |   12 ++++++++++++
> >>> arch/powerpc/include/asm/immap_85xx.h    |   19 +------------------
> >>> 3 files changed, 21 insertions(+), 20 deletions(-)
> >> 
> >> this probably breaks boards.  Did you do a build all on 85xx and 86xx?
> > 
> > No, I didn't try on other boards. The registers have default value of 0,
> > which shouldn't hurt.
> > 
> > York
> > 
> 
> Its not that, I think we fail to even compile.
> 
> For example:
> 
> [galak at right u-boot]$ git grep debug_ board/tqc/
> board/tqc/tqm85xx/sdram.c:      ddr->debug_3 |= 0x00000400;
> board/tqc/tqm85xx/sdram.c:      ddr->debug_3 &= ~0x00000400;
> board/tqc/tqm85xx/sdram.c:      ddr->debug_2 |= 0x00000400;
> board/tqc/tqm85xx/sdram.c:      while (ddr->debug_2 & 0x00000400)
> 

You are right. I didn't think there are other boards out of freescale
folder. Do you want to me revert back to debug_x or change all of them
to debug[x]?

York