[U-Boot] [PATCH 09/10] Adding interactive ddr

[Kumar Gala]

On Dec 14, 2010, at 1:47 AM, Wolfgang Denk wrote:

> Dear York Sun,
> 
> In message <1291863340-4354-9-git-send-email-yorksun at freescale.com> you wrote:
>> Use environment variable to active the interactive debugging.
> ...
> 
> s/active/activate/
> 
>> diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/Makefile b/arch/powerpc/cpu/mpc8xxx/ddr/Makefile
>> index cb7f856..4bd416a 100644
>> --- a/arch/powerpc/cpu/mpc8xxx/ddr/Makefile
>> +++ b/arch/powerpc/cpu/mpc8xxx/ddr/Makefile
>> @@ -11,15 +11,15 @@ include $(TOPDIR)/config.mk
>> LIB	= $(obj)libddr.a
>> 
>> COBJS-$(CONFIG_FSL_DDR1)	+= main.o util.o ctrl_regs.o options.o \
>> -				   lc_common_dimm_params.o
>> +				   lc_common_dimm_params.o interactive.o
>> COBJS-$(CONFIG_FSL_DDR1)	+= ddr1_dimm_params.o
>> 
>> COBJS-$(CONFIG_FSL_DDR2)	+= main.o util.o ctrl_regs.o options.o \
>> -				   lc_common_dimm_params.o
>> +				   lc_common_dimm_params.o interactive.o
>> COBJS-$(CONFIG_FSL_DDR2)	+= ddr2_dimm_params.o
>> 
>> COBJS-$(CONFIG_FSL_DDR3)	+= main.o util.o ctrl_regs.o options.o \
>> -				   lc_common_dimm_params.o
>> +				   lc_common_dimm_params.o interactive.o
>> COBJS-$(CONFIG_FSL_DDR3)	+= ddr3_dimm_params.o
> 
> Building interactive.o should depend on CONFIG_FSL_DDR_INTERACTIVE
> being set.

Agreed

> 
>> SRCS	:= $(START:.o=.S) $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c)
>> diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
>> new file mode 100644
>> index 0000000..7d492a9
>> --- /dev/null
>> +++ b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
>> @@ -0,0 +1,1882 @@
>> +/*
>> + * Copyright 2010 Freescale Semiconductor, Inc.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License
>> + * Version 2 as published by the Free Software Foundation.
>> + */
> 
> NAK.   V2 or later is mandatory.

Yes, we will fix.

- k