[U-Boot] [PATCH] tools: fw_printenv supports mmc device

[Donghwa Lee]

 On 2010-12-16 오후 3:42 , Stefano Babic wrote:
> On 12/16/2010 02:22 AM, Donghwa Lee wrote:
>> diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
>> index 8ff7052..5a707f6 100644
>> --- a/tools/env/fw_env.c
>> +++ b/tools/env/fw_env.c
>> @@ -855,6 +855,7 @@ static int flash_write_buf (int dev, int fd, void *buf, size_t count,
>>  		}
>>  
>>  		erase.start = blockstart;
>> +#ifndef CONFIG_ENV_IS_IN_MMC
> Can we get rid of this #ifdef statement ? This does not allow to include
> the binary in a distro, because it is decided at compile time where the
> environment is stored.
>
> We already check if we are using a flash device in fw_env.c, when we
> call ioctl (fd, MEMGETINFO, &mtdinfo). At the moment, we set the
> mtd_type field in the envdevices structure only with MTD_NORFLASH or
> MTD_NANDFLASH. I think it should be better to improve the check to find
> on which medium we store the environment and set the mtd_type according
> to its result if a SD/MMC is found (with MTD_MMC, maybe ?).
>
I think SD/MMC may not use MEMGETINFO ioctl. If mmc device doesn't use MTD, use only one partition, it can not use MEMGETINFO ioctl?
Actually, environment variables are very small area in SD/MMC, it doesn't need to divide own partition.

But, I think my patch that uses #ifndef statement was wrong, it needs to change another way.
>>  # Notice, that the "Number of sectors" is ignored on NOR.
>>  
>>  # MTD device name	Device offset	Env. size	Flash sector size	Number of sectors
>> -/dev/mtd1		0x0000		0x4000		0x4000
>> -/dev/mtd2		0x0000		0x4000		0x4000
>> +#/dev/mtd1		0x0000		0x4000		0x4000
>> +#/dev/mtd2		0x0000		0x4000		0x4000
> I do not see any change in these lines..
>
yes, there is no change, i added avobe to tell that case of not using /dev/mtd# node.

>>  
>>  # NAND example
>>  #/dev/mtd0		0x4000		0x4000		0x20000			2
>> +
>> +# MMC device name	Device offset	Env. size	Flash sector size	Number of sectors
>> +/dev/mmcblk0		0x7000		0x1000		0x1000
> Do we need Flash sector size for MMC ?
MMC doesn't need to flash sector size. MMC can overwrite.
> Best regards,
> Stefano Babic
>