[U-Boot] [PATCH v2 9/9] corenet_ds: Extend board specific parameters

Wolfgang Denk wd at denx.de
Sat Dec 18 23:20:47 CET 2010


Dear York Sun,

In message <1292630381-23022-9-git-send-email-yorksun at freescale.com> you wrote:
> Extend board specific parameters to include cpo, write leveling override
> Extend write leveling sample to 0xf
> Adding rcw overrid for quad-rank RDIMMs
...
> +	/*	memory controller 0
> +	 *	 lo|  hi|  num|  clk| wrlvl | cpo  |wrdata|2T
> +	 *	mhz| mhz|ranks|adjst| start | delay|
> +	 */

Incorrect multi-line comment style.  Please fix globally.

> +		    pdimm[0].n_ranks == pbsp->n_ranks) {
> +			popts->cpo_override = pbsp->cpo;
> +			popts->write_data_delay = pbsp->write_data_delay;
> +			popts->clk_adjust = pbsp->clk_adjust;
> +			popts->wrlvl_start = pbsp->wrlvl_start;

Indentation by TAB only.  Please fix globally.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you're not part of the solution, then you're part of the  precipi-
tate.


More information about the U-Boot mailing list