[U-Boot] [PATCH] Blackfin: bf518f-ezbrd: don't require SPI logic all the time
Wolfgang Denk
wd at denx.de
Sun Dec 19 00:19:21 CET 2010
Dear Mike Frysinger,
In message <1291891215-12374-1-git-send-email-vapier at gentoo.org> you wrote:
> Only the first run of boards had a ksz switch on it, so if building for a
> newer silicon rev or SPI is disabled, don't bother checking for the ksz.
>
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
...
> + if (!switch_is_alive)
> return -1;
> + else
> + return 0;
> +}
Drop the else, and unindent the return 0;
> +int board_eth_init(bd_t *bis)
> +{
> + if (KSZ_POSSIBLE)
> + if (board_ksz_init() == -1)
> + return 0;
Braces needed for multiline statements.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Computers are not intelligent. They only think they are.
More information about the U-Boot
mailing list