[U-Boot] [PATCH v2] Blackfin: dnp5370: new board port

Wolfgang Denk wd at denx.de
Sun Dec 19 13:27:05 CET 2010


Dear Mike Frysinger,

In message <201012182350.22451.vapier at gentoo.org> you wrote:
>
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -1090,6 +1090,10 @@ Peter Meerwald <devel at bct-electronic.com>
> > > 
> > >  	bct-brettl2	BF536
> > > 
> > > +M.Hasewinkel (MHA) <info at ssv-embedded.de>
> > > +
> > > +	dnp5370		BF537
> > 
> > Please keep list sorted.
>
> the list is already not sorted, nor is it really feasible to do so.  it's 
> grouped by maintainer which may have multiply named boards.

If you don't want to help to clean up (which I can live with), then
please at least do not add to the mess.

> > > +#define CONFIG_IPADDR          10.100.100.21
> > > +#define CONFIG_NETMASK         255.255.0.0
> > > +#define CONFIG_GATEWAYIP       10.100.100.1
> > > +#define CONFIG_SERVERIP        10.100.100.12
> > 
> > NAK.  We do not allow this.
>
> i dont see why.  these are *default* settings.  there is nothing here that 
> prevents people in their own board from overriding at runtime and saving the 
> result into their environment.  where as having default settings often makes 
> new builds/tests a lot smoother.

It's still NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hello! I'm from outer space,  and I've made myself look like a signa-
ture.  While  you  are reading this, I'm having sex with your eyes. I
know it feels good to you, because you're smiling. I'm very horny, so
send me to someone else when you've had enough. Thanks!
                              Sincerely, A Stranger in a Strange Land


More information about the U-Boot mailing list