[U-Boot] [PATCH] Blackfin: bf525-ucr2: new board port

[Wolfgang Denk]

Dear Mike Frysinger,

In message <201012191818.56840.vapier at gentoo.org> you wrote:
>
> > > no, that doesnt make any sense.  just because i want some of the boards i
> > > maintain to favor speed over size doesnt mean every board maintainer
> > > should. thus the settings are in the board-specific config.mk where they
> > > should be.
> > 
> > We have here:
> > 
> > 	CONFIG_BFIN_CPU = bf525-0.2
> > 	LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE))
> > 
> > Which these fall into that group?
>
> i dont understand the question, so i'll just spout random noise.

Well, your argument was the need to provide board or file specific
optimizer options to "favor speed over size ...".  To me it seems this
argument has nothing to do with what the definitions above are doing.

> the LDR_FLAGS-y convention is board specific and is only set in boards' 
> config.mk.  i could unify that convention across all Blackfin boards and move 
> this one specific line to the common Blackfin config.mk, but that still 

OK, then please let's do this.  I guess this will allow to remove a
number of other config.mk files as well.

> wouldnt change the requirement of a board specific config.mk to set up custom 
> LDR_FLAGS for its specific boot modes.  which some Blackfin boards need.

Such config.mk files that are really needed (i. e. for which no easy
other approach exists) may remain.

> as for the cpu selection, obviously that cannot be in any common file since
> the cpu variant and silicon rev is about as board specific as you could 
> possibly get.

And why cannot it be set in the board config file like every other
board doing it?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You Earth people glorified organized violence  for  forty  centuries.
But you imprison those who employ it privately.
	-- Spock, "Dagger of the Mind", stardate 2715.1