[U-Boot] [PATCH v2] microblaze: Disabling interrupt should return 1 if was enabled

Sergei Shtylyov sshtylyov at mvista.com
Tue Dec 21 14:26:20 CET 2010


Hello.

On 21-12-2010 16:02, Michal Simek wrote:

> Microblaze implement enable/disable interrupts through MSR
> that's why disable_interrupts function should return 1 when interrupt
> was enabled. Return 0 when interrupt was disabled.

> Signed-off-by: John Linn<john.linn at xilinx.com>
> Signed-off-by: Michal Simek<monstr at monstr.eu>
[...]

> diff --git a/arch/microblaze/cpu/interrupts.c b/arch/microblaze/cpu/interrupts.c
> index e9d53c1..054e09f 100644
> --- a/arch/microblaze/cpu/interrupts.c
> +++ b/arch/microblaze/cpu/interrupts.c
> @@ -41,8 +41,10 @@ void enable_interrupts (void)
>
>   int disable_interrupts (void)
>   {
> +	unsigned int msr;

    Empty line wouldn't hurt here...

> +	MFS(msr, rmsr);
>   	MSRCLR(0x2);
> -	return 0;
> +	return ((msr & 0x2) != 0);

    External pair of () not needed.

WBR, Sergei


More information about the U-Boot mailing list