[U-Boot] [PATCH 2/2] microblaze: Fix bdiinfo pointer

Michal Simek monstr at monstr.eu
Tue Dec 21 14:51:17 CET 2010


Wolfgang Denk wrote:
> Dear Michal Simek,
> 
> In message <4D10A473.2030202 at monstr.eu> you wrote:
>> I would like to do it but it is not easy to use sizeof because there are 
>> some dependencies in macros in common.h(lines 193-201) because I am 
>> using CONFIG_SYS_GBL_DATA_OFFSET for monitor/malloc areas.
>>
>> The best will be to be able to generate this value in lib/asm-offsets.c
>>
>> Not sure if you are ok with it.
> 
> Yes, this is OK.
> 
>> diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c
>> index 2209561..36fc198 100644
>> --- a/lib/asm-offsets.c
>> +++ b/lib/asm-offsets.c
>> @@ -24,6 +24,8 @@ int main(void)
>>          /* Round up to make sure size gives nice stack alignment */
>>          DEFINE(GENERATED_GBL_DATA_SIZE,
>>                  (sizeof(struct global_data)+15) & ~15);
>> +       DEFINE(GENERATED_BD_INFO_SIZE,
>> +               (sizeof(struct bd_info)+15) & ~15);
>>
>>          return 0;
>>   }
> 
> This patch is white-space corrupted, though.

It wasn't intended as a patch just show if this approach will be acceptable.

I will generate patches based on this.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian


More information about the U-Boot mailing list