[U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style

Wolfgang Denk wd at denx.de
Tue Dec 21 19:55:53 CET 2010


Dear Michal Simek,

In message <1292955178-13018-1-git-send-email-monstr at monstr.eu> you wrote:
> Clear coding style issues.
> 
> Signed-off-by: Michal Simek <monstr at monstr.eu>
> ---
>  lib/asm-offsets.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c
> index 2209561..f1af7e2 100644
> --- a/lib/asm-offsets.c
> +++ b/lib/asm-offsets.c
> @@ -19,11 +19,11 @@
>  
>  #include <linux/kbuild.h>
>  
> -int main(void)
> +int main (void)
>  {
>  	/* Round up to make sure size gives nice stack alignment */
> -	DEFINE(GENERATED_GBL_DATA_SIZE,
> -		(sizeof(struct global_data)+15) & ~15);
> +	DEFINE (GENERATED_GBL_DATA_SIZE,
> +		(sizeof (struct global_data) + 15) & ~15);

These changes are to the worse.  All.  Why do you think this would be
better?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Weekends were made for programming.                 - Karl Lehenbauer


More information about the U-Boot mailing list