[U-Boot] [PATCH] Move DECLARE_GLOBAL_DATA_PTR to file scope

Wolfgang Denk wd at denx.de
Tue Dec 21 20:25:04 CET 2010


Dear John Rigby,

In message <1292894871-1436-1-git-send-email-john.rigby at linaro.org> you wrote:
> It can be optimised out by the compiler otherwise resulting
> in obscure errors like a board not booting.
> 
> This has been documented in README since 2006 when these were
> first fixed up for GCC 4.x.
> 
> Signed-off-by: John Rigby <john.rigby at linaro.org>
> ---
>  arch/arm/cpu/armv7/mx5/speed.c      |    4 ++--
>  arch/blackfin/cpu/serial.c          |    3 ++-
>  arch/m68k/cpu/mcf547x_8x/speed.c    |    4 ++--
>  arch/sh/lib/board.c                 |    4 ++--
>  board/espt/espt.c                   |    4 ++--
>  board/isee/igep0020/igep0020.c      |    4 ++--
>  board/isee/igep0030/igep0030.c      |    4 ++--
>  board/linkstation/linkstation.c     |    3 ++-
>  board/logicpd/zoom1/zoom1.c         |    5 +++--
>  board/logicpd/zoom2/zoom2.c         |    3 ++-
>  board/mpr2/mpr2.c                   |    4 ++--
>  board/ms7720se/ms7720se.c           |    4 ++--
>  board/ms7722se/ms7722se.c           |    4 ++--
>  board/ms7750se/ms7750se.c           |    4 ++--
>  board/overo/overo.c                 |    4 ++--
>  board/pandora/pandora.c             |    4 ++--
>  board/renesas/MigoR/migo_r.c        |    4 ++--
>  board/renesas/ap325rxa/ap325rxa.c   |    4 ++--
>  board/renesas/r2dplus/r2dplus.c     |    4 ++--
>  board/renesas/r7780mp/r7780mp.c     |    4 ++--
>  board/renesas/rsk7203/rsk7203.c     |    4 ++--
>  board/renesas/sh7763rdp/sh7763rdp.c |    4 ++--
>  board/renesas/sh7785lcr/sh7785lcr.c |    4 ++--
>  board/samsung/smdk6400/smdk6400.c   |    4 ++--
>  board/ti/beagle/beagle.c            |    4 ++--
>  board/ti/evm/evm.c                  |    4 ++--
>  board/ti/sdp3430/sdp.c              |    4 ++--
>  drivers/i2c/omap24xx_i2c.c          |    3 ++-
>  drivers/serial/s3c64xx.c            |    3 ++-
>  drivers/serial/serial_s5p.c         |    3 ++-
>  drivers/serial/serial_sh.c          |    5 +++--
>  31 files changed, 64 insertions(+), 56 deletions(-)

Applied to master (with the additional fixes I mentioned).  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Where people stand is not as important as which way they face.
        - Terry Pratchett & Stephen Briggs, _The Discworld Companion_


More information about the U-Boot mailing list