[U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style
Wolfgang Denk
wd at denx.de
Tue Dec 21 22:11:31 CET 2010
Dear Michal Simek,
In message <4D1107D2.7070607 at monstr.eu> you wrote:
>
> > These changes are to the worse. All. Why do you think this would be
> > better?
>
> It is what intend suggest to do.
> intend -npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1 -pcs
Please omit the "-pcs" part. It has always been my personal
preference, but I've been overruled, and we use plain Lindent these
days.
> I am OK to remove space between macro name and argument as you suggested
> in your other email.
>
> >> + DEFINE (GENERATED_GBL_DATA_SIZE,
> >> + (sizeof (struct global_data) + 15) & ~15);
> ^ ^ ^ ^
>
> I believe that marked space are OK, or not?
Yes.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If God had wanted us to use the metric system, Jesus would have had
10 apostles."
More information about the U-Boot
mailing list