[U-Boot] [PATCH 3/3] imximage: Add MX53 boot image support

[Stefano Babic]

On 12/28/2010 09:08 AM, Jason Liu wrote:
>>> +#ifdef CONFIG_MX51
>>
>> NAK. This is wrong: mkimage is a tool running on host and must be
>> possible to include it in a distro. It must be able (as it now does) to
>> produce the correct image at runtime. For this reason there are no
>> #ifdef in the actual code. If a different behavior is required, this
>> must be added extending the syntax of the imximage.cfg file, for example
>> adding a processor type (or a version number, or whatever is needed).
> 
> Sorry, I don't notice that. If that, I have to add extending syntax to
> support mx53 since
> mx53 is different with mx51 for ROM boot structure.
> 
> I would like to add one process type into the imximage.cfg file, what
> do you think of that?
> Any suggestions? Thanks,

You have sure in Freescale a better visibility how to group together
this feature. Is the newer header typical for the MX53 or are there
other processors using the same structure ? John has already pointed out
that the MX28 is very similar, and, after reading the manual, it seems
to me it has the same header as the MX53. Can we distinguish with a
header version ?

As I can see, the actual header is used at least by the MX35, not only
by the MX51. So I would prefer a way to group together processors with
the same header structure else to define a processor type.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================