[U-Boot] [PATCH v3 3/3] MX5:MX53: add initial support for MX53EVK board

[Stefano Babic]

On 12/29/2010 01:38 PM, Jason Liu wrote:
> Add initial support for MX53EVK board support.
> FEC, SD/MMC, UART, I2C, have been support.
> 
> Signed-off-by: Jason Liu <r64343 at freescale.com>

Hi Jason,

> Changes for v3:
> - put uart and fec iomux setting to board_early_init_f so that uart can print
>   out the early information such as uboot banner and cpuinfo etc.
> - put mxc_gpio patch into this commit according to Stefno comments,

This is not what I meant. I told to put the mxc_gpio patch into this
patchset (as you have now done, [PATCH v3 4/8] mxc_gpio: add support for
MX53 processor is in this patchset), but not to duplicate the patch
inside this commit. In fact, I cannot apply your patches, as they are
changing the same file.

> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0590ad9..698d401 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -555,6 +555,10 @@ Stefano Babic <sbabic at denx.de>
>  	mx51evk		i.MX51
>   	vision2		i.MX51
>  
> +Jason Liu <r64343 at freescale.com>
> +
> +	MX53evk         i.MX53
> +
>  Enric Balletbo i Serra <eballetbo at iseebcn.com>

Please maintain the list *alfabetically* sorted.


> --- a/drivers/gpio/mxc_gpio.c
> +++ b/drivers/gpio/mxc_gpio.c
> @@ -24,7 +24,7 @@
>  #ifdef CONFIG_MX31
>  #include <asm/arch/mx31-regs.h>
>  #endif
> -#ifdef CONFIG_MX51

Drop these changes from this patch, as we have them in the [PATCH v3 4/8].

> +/***********************************************************
> + * Command definition
> + ***********************************************************/

Multiline comment, please fix globally in this file.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================