[U-Boot] [PATCH v3 1/8] MX5: Add initial support for MX53 processor

[Jason Liu]

Hi, Stefano,

2010/12/30 Stefano Babic <sbabic at denx.de>:
> On 12/29/2010 01:38 PM, Jason Liu wrote:
>> Add initial support for Freescale MX53 processor,
>>
>> - Add the iomux support and the pin definition,
>> - Add the regs definition, clean up some unused def from mx51,
>> - Add the low level init support, make use the freq input of setup_pll macro
>
> Hi Jason,
>
>> diff --git a/arch/arm/include/asm/arch-mx5/asm-offsets.h b/arch/arm/include/asm/arch-mx5/asm-offsets.h
>> index afd2728..2258f2f 100644
>> --- a/arch/arm/include/asm/arch-mx5/asm-offsets.h
>> +++ b/arch/arm/include/asm/arch-mx5/asm-offsets.h
>> @@ -37,7 +37,12 @@
>>  #define CLKCTL_CCGR4            0x78
>>  #define CLKCTL_CCGR5            0x7C
>>  #define CLKCTL_CCGR6            0x80
>> +#if defined(CONFIG_MX53)
>> +#define CLKCTL_CCGR7            0x84
>>  #define CLKCTL_CMEOR            0x84
>> +#elif defined(CONFIG_MX51)
>> +#define CLKCTL_CMEOR            0x84
>> +#endif
>
> It seems to me that CLKCTL_CMEOR should be dropped in the CONFIG_MX53
> case, as its offset is reserved for CLKCTL_CCGR7.

I will fix the CLKCTL_CMEOR offset in MX53. Thanks for the careful review.

>
>> -/*!
>>   * Number of GPIO port as defined in the IC Spec
>>   */
>>  #define GPIO_PORT_NUM                4
>
> I see now that GPIO_PORT_NUM seems superfluous, and it is not used in
> any part of code. Please drop it :-)

OK,

>
> Best regards,
> Stefano Babic
>
> --
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>