[U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

Wolfgang Denk wd at denx.de
Sat Feb 6 15:24:59 CET 2010


Dear Minkyu Kang,

In message <1f3430fb1002060418ydd28583sb6051dd1517fa864 at mail.gmail.com> you wrote:
> 
> > Changes the names of the s3c24x0 register struct members from upper-case
> > to lower-case.
...
> Sorry for late reply.
> I tried to review your patch series,
> but your patch is too confusion, because of files are scattered in
> every patches.

Well, but that's only natural, as the use of these names is scattered
all over the place.

> If possible, could you please remake patches?
> Please make to one file's modification by one patch.

This request makes no sense at all. If you change a variable name, you
*must* change all places where it hgets used within the same commit.

The splitting you suggest would make things worse.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"And they told us, what they wanted... Was a sound  that  could  kill
some-one, from a distance."                               - Kate Bush


More information about the U-Boot mailing list