[U-Boot] [PATCH 3/3] SAMSUNG: SMDKC100: Adds ethernet support.

Ben Warren biggerbadderben at gmail.com
Wed Feb 10 06:40:01 CET 2010


Hi Naveen,

On 2/9/2010 8:53 PM, Naveen Krishna Ch wrote:
> Hi Ben,
>
> I think you wanted me to remove the CONFIG_BOOTP_* macros.
> But the gmail is showing some other code under ur comments.
>
> Any how i wil remove the CONFIG_BOOTP_* macros and submit a
> V2 version of the patch.
>
I don't have a problem with the CONFIG_BOOTP macros as long as you put 
them there intentionally rather than as a cut&paste.  My quarrel was 
with the MAC and IP address assignments.  It looks like you've removed 
those, so it's all OK.

regards,
Ben


More information about the U-Boot mailing list