[U-Boot] [PATCH 2/2 v3] arm: suen3, suen3_v1, mgcoge2_arm_p1a support

[Heiko Schocher]

Hello Prafulla,

tahnks for your quick response!

Prafulla Wadaskar wrote:
>> -----Original Message-----
>> From: Heiko Schocher [mailto:hs at denx.de] 
>> Sent: Wednesday, February 10, 2010 12:39 PM
>> To: Prafulla Wadaskar
>> Cc: U-Boot user list
>> Subject: Re: [PATCH 2/2 v3] arm: suen3, suen3_v1, 
>> mgcoge2_arm_p1a support
>>
>> Hello Prafulla,
>>
>> do you have some comments on the following 2 points?
>> (If they are clarified, I can post v4 of the patch ...)
>>
>> Heiko Schocher wrote:
>>> Prafulla Wadaskar wrote:
>>>>> -----Original Message-----
>>>>> From: Heiko Schocher [mailto:hs at denx.de] 
>>>>> Sent: Monday, February 01, 2010 1:07 PM
>>>>> To: U-Boot user list
>>>>> Cc: Wolfgang Denk; Prafulla Wadaskar; Tom
>>>>> Subject: [PATCH 2/2 v3] arm: suen3, suen3_v1, 
>> mgcoge2_arm_p1a support
> ...snip...
>>>> the include/config files indicates that there are five 
>> board supports.
>>>> Please provide one patch for each board, may be first will 
>> be master one.
>>> This question also asked Tom, see:
>>>
>>> http://lists.denx.de/pipermail/u-boot/2010-January/067182.html
>>>
>>> But if you prefer to split this in 5 patches, I can do it.
>> Is it OK in one patch, or should I split it in 4 patches?
> 
> Dear Heiko
> 
> You should split it in patches as per boards supported, if you are supporting four board then there should be four different patches.

OK.

>> [...]
>>>>> diff --git a/board/keymile/km_arm/sdramregs.txt 
>>>>> b/board/keymile/km_arm/sdramregs.txt
>>>>> new file mode 100644
>>>>> index 0000000..68c53a7
>>>>> --- /dev/null
>>>>> +++ b/board/keymile/km_arm/sdramregs.txt
>>>>> @@ -0,0 +1,31 @@
>>>> What is this file?
>>>> Which license?
>>>> Who is using it?
>>> Ok, you are right, some comments are here necessary.
>>>
>>> On this boards is a preloader, which initializes
>>> the RAM. Therefore the preloader reads the RAM settings
>>> from the image he should load, through an hear. This
>>> header is created with a tool doimage (I think it is
>>> from marvell), and this tool needs this file ...
> 
> Marvell Kirkwood has internal bootROM and it may be active through h/w configuration on you board.
> In such case bootROM tries to read Kirkwood boot image (i.e. kwbimage) from boot media (i.e. NAND/SPI/Sata etc).
> 
> So kwbimage.cfg (the above file that you have created) should be present in board folder and this will be used by mkimage tool if you create u-boot.kwb target.

Ah, OK!

>>> So, I have no idea where to put this files, and think
>>> they are in the board directory on the right place ...
> 
> Please refer docs/README.kwbimage

Ok, found it, thanks

>>> I found something similiar in current mainline:
>>>
>>> board/Marvell/mv88f6281gtw_ge/dramregs_333h.txt
> 
> There is kwbimage.cfg and not dramregs_333h.txt, may be you are referring very early post

Yep, sorry.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany