[U-Boot] [PATCH]: common/cmd_flash.c: bug-fix

Teh Kok How khteh at smartbridges.com
Mon Feb 22 06:36:37 CET 2010


Hi Wolfgang;
	Sorry, been away for 1 week. The constant 10 is the size of an array
that is arbitrarily chosen so that it is big enough to hold the current mtd
device identifier such as nor0, nor1, nor2, nand0, nand1, nand2, etc.

Regards,
KH

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de] 
Sent: Friday, February 12, 2010 11:28 PM
To: Teh Kok How
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH]: common/cmd_flash.c: bug-fix

Dear "Teh Kok How",

In message <89D4E2CB6B654B3FB0DA6A0CE6650515 at smartbridges.com> you wrote:
>
> --- u-boot-2009.11.1.orig/common/cmd_flash.c    2010-01-25
> 16:35:12.000000000 +0800
> +++ u-boot-2009.11.1.new/common/cmd_flash.c     2010-02-12
> 16:18:10.565540182 +0800
> @@ -43,6 +43,7 @@
> 
>  #ifndef CONFIG_SYS_NO_FLASH
>  extern flash_info_t flash_info[];      /* info for FLASH chips */
> +extern struct mtd_device *current_mtd_dev;
> 
>  /*
>   * The user interface starts numbering for Flash banks with 1
> @@ -331,6 +332,7 @@
>         u8 dev_type, dev_num, pnum;
>  #endif
>         int rcode = 0;
> +       char mtd_dev[10];

Where is this magic constant 10 coming from?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Why is an average signature file longer than an average Perl script??



More information about the U-Boot mailing list